Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup): pass options to resolve #2842

Merged
merged 2 commits into from
Nov 3, 2024
Merged

fix(rollup): pass options to resolve #2842

merged 2 commits into from
Nov 3, 2024

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Nov 3, 2024

Resolves #2841

Rollup expects resolve options from resolveId to be passed through.

skipSelf: true override removed for static since it is now default behavior in rollup.

@pi0 pi0 self-assigned this Nov 3, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 3, 2024

Deploying nitrojs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a723e3f
Status: ✅  Deploy successful!
Preview URL: https://3b7fd883.nitrojs.pages.dev
Branch Preview URL: https://fix-static-resolveid.nitrojs.pages.dev

View logs

@pi0 pi0 mentioned this pull request Nov 3, 2024
@pi0 pi0 merged commit f6e1efc into v2 Nov 3, 2024
5 checks passed
@pi0 pi0 deleted the fix/static-resolveid branch November 3, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build server
1 participant