Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: fix type for event.$fetch #2913

Merged
merged 1 commit into from
Dec 3, 2024
Merged

types: fix type for event.$fetch #2913

merged 1 commit into from
Dec 3, 2024

Conversation

danielroe
Copy link
Member

🔗 Linked issue

nuxt/nuxt#30091

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

currently the types are incorrect (they include .raw and .create). This refactors the base '$fetch' type into Base$Fetch so this can be used to type event.$fetch without needing workarounds.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 as a code owner December 2, 2024 15:38
@danielroe danielroe self-assigned this Dec 2, 2024
@danielroe danielroe added bug Something isn't working types labels Dec 2, 2024
pi0
pi0 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@pi0 pi0 changed the title fix: extract Base$Fetch type for typing event.$fetch types: fix type for event.$fetch Dec 3, 2024
@pi0 pi0 merged commit 066c478 into v2 Dec 3, 2024
5 checks passed
@pi0 pi0 deleted the fix/event-fetch branch December 3, 2024 11:08
@danielroe
Copy link
Member Author

shall I remake for v3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
bug Something isn't working types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0