Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade rollup to 3.x #580

Merged
merged 9 commits into from
Dec 12, 2022
Merged

feat!: upgrade rollup to 3.x #580

merged 9 commits into from
Dec 12, 2022

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 15, 2022

Resolves #569

WIP: There are some internal plugins to be updated

Dependant plugin updates:

├─┬ rollup-plugin-terser 7.0.2
│ └── ✕ unmet peer rollup@^2.0.0: found 3.2.0
└─┬ rollup-plugin-visualizer 5.8.2
  └── ✕ unmet peer rollup@^2.0.0: found 3.2.0

Copy link
Member

If we merge + release this, is there a chance this will produce package manager issues as long as vite is still using rollup v2? (Might be worth testing on npm, yarn & pnpm within a nuxt project before merging.)

@pi0
Copy link
Member Author

pi0 commented Oct 15, 2022

I guess rollup 2 is directly bundled into vite. I hope there are not issues with rollup plugins implicitly used for vite. But surely we can do a sanity check before...

Copy link
Member

danielroe commented Oct 15, 2022

rollup 2 is a dependency of vite and not bundled into it. Rollup 3 support is planned for an upcoming major release. I doubt there will be issues with the official rollup plugins, which seem to be designed to be compatible with both 2/3.

@pi0
Copy link
Member Author

pi0 commented Oct 15, 2022

Ah right seems not bundled anymore 🤦🏼‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to rollup v3
2 participants