feat: extended cloudflare context #677
Conversation
src/runtime/entries/cloudflare.ts
Outdated
| function toNodeListener (app: App, context: H3EventContext): NodeListener { | ||
| const toNodeHandle: NodeListener = async function (req, res) { | ||
| const event = createEvent(req, res) | ||
| event.context = { ...event.context, ...context } |
There was a problem hiding this comment.
I think we might want to add CF context as event.context.cloudflare for better type support.
There was a problem hiding this comment.
| event.context = { ...event.context, ...context } | |
| event.context = { ...event.context, cloudflare: context } |
There was a problem hiding this comment.
Oops - didn't mean to edit. What about?
| event.context = { ...event.context, ...context } | |
| event.context.cloudflare = context |
There was a problem hiding this comment.
Thanks for feedback, implemented 🙌
Codecov Report
@@ Coverage Diff @@
## main #677 +/- ##
=======================================
Coverage 66.91% 66.91%
=======================================
Files 57 57
Lines 4232 4232
Branches 459 460 +1
=======================================
Hits 2832 2832
Misses 1397 1397
Partials 3 3 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| function toNodeListener (app: App, context: H3EventContext): NodeListener { | ||
| const toNodeHandle: NodeListener = async function (req, res) { | ||
| const event = createEvent(req, res) | ||
| event.context.cloudflare = context |
There was a problem hiding this comment.
Should this be:
| event.context.cloudflare = context | |
| event.context.cloudflare = context.cf |
There was a problem hiding this comment.
I think the answer to this depends on where you'll want the fetch event context to live when module syntax support lands in #681.
|
Thanks for working on this @barisbora ❤️ Adding support with a slightly more generic approach in #927 |
🔗 Linked issue
resolves #391
❓ Type of change
📚 Description
Extending context object with cloudflare CF Properties and headers
📝 Checklist