Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter unique scanned handlers #807

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Conversation

yassilah
Copy link
Contributor

@yassilah yassilah commented Jan 6, 2023

πŸ”— Linked issue

Resolves #806

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #807 (b2b6508) into main (78808dd) will decrease coverage by 2.86%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
- Coverage   70.15%   67.28%   -2.87%     
==========================================
  Files          57       58       +1     
  Lines        5234     5744     +510     
  Branches      576      610      +34     
==========================================
+ Hits         3672     3865     +193     
- Misses       1553     1871     +318     
+ Partials        9        8       -1     
Impacted Files Coverage Ξ”
src/scan.ts 66.97% <66.66%> (+0.63%) ⬆️
src/presets/netlify.ts 60.00% <0.00%> (-0.37%) ⬇️
src/dev/vfs.ts 10.00% <0.00%> (-0.31%) ⬇️
src/types/nitro.ts 100.00% <0.00%> (ΓΈ)
src/rollup/plugins/dynamic-require.ts 26.56% <0.00%> (ΓΈ)
src/rollup/plugins/externals-legacy.ts 6.80% <0.00%> (ΓΈ)
src/prerender.ts 89.19% <0.00%> (+0.03%) ⬆️
src/utils/index.ts 51.83% <0.00%> (+0.52%) ⬆️
src/rollup/config.ts 92.12% <0.00%> (+0.54%) ⬆️
src/nitro.ts 87.77% <0.00%> (+0.56%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title fix: filter unique route/method handlers fix: filter unique scaned handlers Jan 16, 2023
@pi0 pi0 changed the title fix: filter unique scaned handlers fix: filter unique scanned handlers Jan 16, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks πŸ’―

@pi0 pi0 merged commit ca35421 into nitrojs:main Jan 16, 2023
@yassilah yassilah deleted the filter-scan-dirs branch January 16, 2023 13:19
@yassilah
Copy link
Contributor Author

Hi! I think this PR unintentionally caused that important issue: nuxt/nuxt#18515. I believe the filtering function should only be applied to api routes and not middlewares

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only keep a single route/method handler when scanning directories
2 participants