Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: lint with eslint --cache and improve types in .eslintrc #863

Merged
merged 1 commit into from
Jan 23, 2023
Merged

chore: lint with eslint --cache and improve types in .eslintrc #863

merged 1 commit into from
Jan 23, 2023

Conversation

o-az
Copy link
Member

@o-az o-az commented Jan 21, 2023

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@o-az
Copy link
Member Author

o-az commented Jan 21, 2023

@pi0 I also converted .eslintrc to .eslintrc.cjs in order to import types. Now eslint config file has autocomplete support. The eslint types don't require installing a separate types package. What do you think?

pi0
pi0 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

@pi0 pi0 changed the title feat: add eslint cache & import types in config file chore: lint with eslint --cache and improve types in .eslintrc Jan 23, 2023
@pi0 pi0 merged commit 02556e6 into nitrojs:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@o-az @pi0