Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve server assets dir relative to srcDir #893

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#18587

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We are now resolving server assets dirs before this point (#825), when options are resolved. We probably still need to resolve server dirs when adding them after this point.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jan 28, 2023
@danielroe danielroe requested a review from pi0 January 28, 2023 22:56
@danielroe danielroe self-assigned this Jan 28, 2023
@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #893 (dc7c56b) into main (917c7e6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #893   +/-   ##
=======================================
  Coverage   67.47%   67.47%           
=======================================
  Files          59       59           
  Lines        5860     5860           
  Branches      635      637    +2     
=======================================
  Hits         3954     3954           
  Misses       1897     1897           
  Partials        9        9           
Impacted Files Coverage Ξ”
src/nitro.ts 89.21% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title fix: resolve server assets dir fix: resolve server assets dir relative to srcDir Jan 30, 2023
@pi0 pi0 merged commit 762ee47 into main Jan 30, 2023
@pi0 pi0 deleted the fix/server-assets branch January 30, 2023 11:45
@pi0
Copy link
Member

pi0 commented Jan 30, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants