Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flightcontrol preset #970

Merged

Conversation

bahdcoder
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This change adds a new deployment provider to Nitro: deploying to AWS via Flightcontrol. Flightcontrol helps you deploy your Nitro projects (Both static & SSR) to your own AWS account with little to no configuration.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0
Copy link
Member

pi0 commented Feb 21, 2023

This is amazing. Do you mind to add a dedicated flightcontrol to the presets too? (https://github.com/unjs/nitro/tree/main/src/presets)

@bahdcoder
Copy link
Contributor Author

Thanks @pi0 . Absolutely. Will ping soon once I have the update.

@pi0 pi0 changed the title docs(deploy): add aws via flightcontrol feat: add aws via flightcontrol Feb 21, 2023
@pi0 pi0 marked this pull request as draft February 21, 2023 17:58
@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Mar 1, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview e9f2eb1

@bahdcoder
Copy link
Contributor Author

@pi0 I added the preset. Can you please double check if all looks okay?

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #970 (e9f2eb1) into main (58cde15) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
+ Coverage   76.62%   76.64%   +0.01%     
==========================================
  Files          69       70       +1     
  Lines        7081     7087       +6     
  Branches      706      706              
==========================================
+ Hits         5426     5432       +6     
  Misses       1654     1654              
  Partials        1        1              
Impacted Files Coverage Ξ”
src/presets/flightcontrol.ts 100.00% <100.00%> (ΓΈ)
src/presets/index.ts 100.00% <100.00%> (ΓΈ)

@ModupeD
Copy link
Contributor

ModupeD commented May 18, 2023

This should be closed, I opened a new request for the docs to be added here: #1250

pi0 and others added 2 commits June 20, 2023 16:59
Co-Authored-By: ModupeD <69601432+ModupeD@users.noreply.github.com>
@pi0 pi0 changed the title feat: add aws via flightcontrol feat: add flightcontrol preset Jun 20, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry for delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants