Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(upgrade): upgrade ng-sortgrid to Angular 10 #47

Merged
merged 4 commits into from
Aug 27, 2020

Conversation

nivekcode
Copy link
Owner

BREAKING CHANGE: upgrade ng-sortgrid to Angular 10

BREAKING CHANGE: upgrade ng-sortgrid to Angular 10
@nivekcode nivekcode linked an issue Aug 26, 2020 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@067f724). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #47   +/-   ##
=========================================
  Coverage          ?   94.95%           
=========================================
  Files             ?        9           
  Lines             ?      218           
  Branches          ?       22           
=========================================
  Hits              ?      207           
  Misses            ?       11           
  Partials          ?        0           
Impacted Files Coverage Δ
...id/src/lib/helpers/element/ngsg-elements.helper.ts 100.00% <0.00%> (ø)
...grid/src/lib/mutliselect/ngsg-selection.service.ts 100.00% <0.00%> (ø)
...ts/ng-sortgrid/src/lib/store/ngsg-store.service.ts 89.47% <0.00%> (ø)
...rtgrid/src/lib/helpers/class/ngsg-class.service.ts 100.00% <0.00%> (ø)
...id/src/lib/helpers/scroll/scroll-helper.service.ts 100.00% <0.00%> (ø)
.../ng-sortgrid/src/lib/shared/ngsg-events.service.ts 100.00% <0.00%> (ø)
...id/src/lib/sort/reflection/ngsg-reflect.service.ts 100.00% <0.00%> (ø)
...ng-sortgrid/src/lib/sort/sort/ngsg-sort.service.ts 96.42% <0.00%> (ø)
...rojects/ng-sortgrid/src/lib/ngsg-item.directive.ts 89.18% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 067f724...6446477. Read the comment docs.

@nivekcode nivekcode linked an issue Aug 27, 2020 that may be closed by this pull request
@nivekcode nivekcode merged commit 269d013 into master Aug 27, 2020
@nivekcode nivekcode deleted the feature/angular10 branch August 27, 2020 13:03
@nivekcode
Copy link
Owner Author

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Jest Does not work at all with angular 10
2 participants