Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dagger repository #621

Merged
merged 2 commits into from
Oct 30, 2023
Merged

add dagger repository #621

merged 2 commits into from
Oct 30, 2023

Conversation

sagikazarmark
Copy link
Contributor

@sagikazarmark sagikazarmark commented Oct 30, 2023

The following points apply when adding a new repository to repos.json

  • I ran ./bin/nur format-manifest after updating repos.json (We will use the same script in github actions to make sure we keep the format consistent)
  • By including this repository in NUR I give permission to license the
    content under the MIT license.

Clarification where license should apply:
The license above does not apply to the packages built by the Nix Packages
collection, merely to the package descriptions (i.e., Nix expressions, build
scripts, etc.). It also might not apply to patches included in Nixpkgs, which
may be derivative works of the packages to which they apply. The aforementioned
artifacts are all covered by the licenses of the respective packages.


For reference: NixOS/nixpkgs#260848

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@Mic92
Copy link
Member

Mic92 commented Oct 30, 2023

I guess the apache license is also fine (afaik compatible to MIT). I sticked to MIT because this is what most of the nix code is licensed as including nixpkgs. This way we don't have to worry about license incompatibility.

@sagikazarmark
Copy link
Contributor Author

@Mic92 thanks for the quick reply. I'm talking to the Dagger folks to figure out if they want to keep Apache 2.0 which is why I kept it a draft for now.

Tagging @gerhard

Either works for me. If Apache 2.0 is fine, I'll mark it as ready and we are done.

@sagikazarmark sagikazarmark marked this pull request as ready for review October 30, 2023 16:34
@sagikazarmark
Copy link
Contributor Author

The decision has been made to revert license to MIT. This PR is good to go.

Thank you all!

@Mic92
Copy link
Member

Mic92 commented Oct 30, 2023

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Oct 30, 2023

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 771f9aa

@mergify mergify bot merged commit 771f9aa into nix-community:master Oct 30, 2023
3 checks passed
@sagikazarmark sagikazarmark deleted the dagger branch October 30, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants