-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Dev380 repository #801
Conversation
CI passes now that I've removed a package that depends on an overlay from a flake input; I'm assuming I need to tweak my CI like this repo did? https://github.com/nix-community/nur-combined/tree/f7a814854548f8cba30e8f2258d1d4d45f78e830/repos/cryolitia |
Right now, NUR is not flake-centric, and uses the package's default.nix. Therefore, for the time being, you'll need to pull rust-overlay either in your default.nix. Alternatively, consider using nixpkgs' built-in rust tooling. |
I followed the second suggestion and switched to the regular nixpkgs.rustPlatform. Github actions buillds now I think, but only since I changed from nixpkgs-unstable to nixos-unstable (for some reason the wisdom-tree python package only builds on the later). Do I have to mark it as only working on nixos-unstable somehow or is it fine as-is? |
I believe it's fine as-is. I'd recommend you submit a build failure issue to nixpkgs; that kind of report is greatly appreciated, as you probably won't be the only one that's affected! |
Strangely enough, the latest nixpkgs-unstable works again. Maybe there was just a temporary issue on that nixos-unstable didn't get yet 🤷 |
Is there anything else I need to fix in my nur repo before it's merged? |
Nope! @mergify queue |
Did mergify not see your comment? |
Yea, looks like it didn't trigger. |
☑️ The pull request will automatically be requeuedMerge queue reset: an external action moved the base branch head to a075770 |
@mergify queue |
🛑 The pull request has been merged manuallyThe pull request has been merged manually at 58a268e |
This pull request has been removed from the queue for the following reason: Pull request #801 has been dequeued. The pull request has been merged manually. The pull request has been merged manually at 58a268e. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
The following points apply when adding a new repository to repos.json
./bin/nur format-manifest
after updatingrepos.json
(We will use the same script in github actions to make sure we keep the format consistent)content under the MIT license.
Clarification where license should apply:
The license above does not apply to the packages built by the Nix Packages
collection, merely to the package descriptions (i.e., Nix expressions, build
scripts, etc.). It also might not apply to patches included in Nixpkgs, which
may be derivative works of the packages to which they apply. The aforementioned
artifacts are all covered by the licenses of the respective packages.