Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Dev380 repository #801

Merged
merged 2 commits into from
Dec 13, 2024
Merged

add Dev380 repository #801

merged 2 commits into from
Dec 13, 2024

Conversation

Dev380
Copy link
Contributor

@Dev380 Dev380 commented Dec 10, 2024

The following points apply when adding a new repository to repos.json

  • I ran ./bin/nur format-manifest after updating repos.json (We will use the same script in github actions to make sure we keep the format consistent)
  • By including this repository in NUR I give permission to license the
    content under the MIT license.

Clarification where license should apply:
The license above does not apply to the packages built by the Nix Packages
collection, merely to the package descriptions (i.e., Nix expressions, build
scripts, etc.). It also might not apply to patches included in Nixpkgs, which
may be derivative works of the packages to which they apply. The aforementioned
artifacts are all covered by the licenses of the respective packages.

@Dev380
Copy link
Contributor Author

Dev380 commented Dec 10, 2024

CI passes now that I've removed a package that depends on an overlay from a flake input; I'm assuming I need to tweak my CI like this repo did? https://github.com/nix-community/nur-combined/tree/f7a814854548f8cba30e8f2258d1d4d45f78e830/repos/cryolitia

@Pandapip1
Copy link
Contributor

Right now, NUR is not flake-centric, and uses the package's default.nix. Therefore, for the time being, you'll need to pull rust-overlay either in your default.nix. Alternatively, consider using nixpkgs' built-in rust tooling.

@Dev380
Copy link
Contributor Author

Dev380 commented Dec 11, 2024

I followed the second suggestion and switched to the regular nixpkgs.rustPlatform. Github actions buillds now I think, but only since I changed from nixpkgs-unstable to nixos-unstable (for some reason the wisdom-tree python package only builds on the later). Do I have to mark it as only working on nixos-unstable somehow or is it fine as-is?

@Pandapip1
Copy link
Contributor

Do I have to mark it as only working on nixos-unstable somehow or is it fine as-is?

I believe it's fine as-is. I'd recommend you submit a build failure issue to nixpkgs; that kind of report is greatly appreciated, as you probably won't be the only one that's affected!

@Dev380
Copy link
Contributor Author

Dev380 commented Dec 12, 2024

Strangely enough, the latest nixpkgs-unstable works again. Maybe there was just a temporary issue on that nixos-unstable didn't get yet 🤷

@Dev380
Copy link
Contributor Author

Dev380 commented Dec 12, 2024

Is there anything else I need to fix in my nur repo before it's merged?

@Pandapip1
Copy link
Contributor

Nope!

@mergify queue

@Dev380
Copy link
Contributor Author

Dev380 commented Dec 13, 2024

Did mergify not see your comment?

@Pandapip1
Copy link
Contributor

Yea, looks like it didn't trigger.

Copy link
Contributor

mergify bot commented Dec 13, 2024

queue

☑️ The pull request will automatically be requeued

Merge queue reset: an external action moved the base branch head to a075770

@Pandapip1
Copy link
Contributor

@mergify queue

Copy link
Contributor

mergify bot commented Dec 13, 2024

queue

🛑 The pull request has been merged manually

The pull request has been merged manually at 58a268e

@Pandapip1 Pandapip1 merged commit 58a268e into nix-community:master Dec 13, 2024
3 checks passed
Copy link
Contributor

mergify bot commented Dec 13, 2024

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #801 has been dequeued. The pull request has been merged manually. The pull request has been merged manually at 58a268e.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants