feat/service improvements #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switch to dynamic user and remove user/group creation * remove bind mounts, using the systemd state directory * refactor some common code and config into lib
If different packages with the same binary name are added to the path it will conflict. We explicitly reference the package in the service configs.
Also make them default values, allowing user's to override later without having to use mkForce
|
@selfuryon when implementing #89 and #90 you should base your new services on the new pattern in this PR. |
Got that, I will do, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the service implementations, re-using common code between them and removing anything related to management of mounts which will be done separately in a new module.