update the reason why we have to use a newer sdk for macOS

nix-community · Sep 13, 2023 · 0ec0d58 · 0ec0d58
1 parent c169a11
commit 0ec0d58
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/flake.nix b/flake.nix
@@ -23,8 +23,8 @@
         let
           pkgs = nixpkgs.legacyPackages.${system};
 
-          # The newer Darwin SDK does not exist in current (nixos-22.05) stable
-          # branches, so just fallback to the default callPackage.
+          # The current default sdk for macOS fails to compile go projects, so we use a newer one for now.
+          # This has no effect on other platforms.
           callPackage = pkgs.darwin.apple_sdk_11_0.callPackage or pkgs.callPackage;
 
           inherit (callPackage ./builder {

diff --git a/overlay.nix b/overlay.nix
@@ -1,7 +1,7 @@
 final: prev:
 let
-  # The newer Darwin SDK does not exist in current (nixos-22.05) stable
-  # branches, so just fallback to the default callPackage.
+  # The current default sdk for macOS fails to compile go projects, so we use a newer one for now.
+  # This has no effect on other platforms.
   callPackage = final.darwin.apple_sdk_11_0.callPackage or final.callPackage;
 in
 {

diff --git a/templates/app/flake.nix b/templates/app/flake.nix
@@ -10,12 +10,16 @@
       (system:
         let
           pkgs = nixpkgs.legacyPackages.${system};
+
+          # The current default sdk for macOS fails to compile go projects, so we use a newer one for now.
+          # This has no effect on other platforms.
+          callPackage = pkgs.darwin.apple_sdk_11_0.callPackage or pkgs.callPackage;
         in
         {
-          packages.default = pkgs.callPackage ./. {
+          packages.default = callPackage ./. {
              inherit (gomod2nix.legacyPackages.${system}) buildGoApplication;
           };
-          devShells.default = pkgs.callPackage ./shell.nix {
+          devShells.default = callPackage ./shell.nix {
              inherit (gomod2nix.legacyPackages.${system}) buildGoApplication mkGoEnv;
           };
         })