-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix symlink builder to recursively walk the vendor directory #121
Fix symlink builder to recursively walk the vendor directory #121
Conversation
Friendly bump on this PR. I also ran into this issue which this PR fixes. |
I am running into that issue as well. |
@niklashhh while we await a maintainer, I too wish to use your branch. Would you please rebase onto master? |
Can confirm too this fixes the issue (I rebased on my own fork). Also kudos on replacing a todo block with a single function that does the right thing — it's nice to see some care taken in this sort of thing. @adisbladis you are listed as the maintainer; would you please arrange for a review? |
@dbaynard Thanks for the kind words! I have updated the branch. Have not tested that everything works as expected though, so please verify before merging! |
This is now needed to build AWS SDK v2 (specifically SSO service). Without it, you get an error:
Another clue is that I then changed to https://github.com/batteries-included/gomod2nix/commit/9febec02ae10d88d0bebb7ef3fe1c06f35c98c5d and builds succeeded in nix again. |
@Mic92 could you please review/merge this? |
@isubasinghe I don't have the capacity to maintain this and I am not using gomod2nix anywhere. |
Okay thanks @Mic92 for the update |
This patch causes the following panic for discourse_distrust (a go app I am using in my deployment):
I have no idea how any of this works, will debug further later |
The recursive symlinker fix has been merged. Fix symlink builder to recursively walk the vendor directory by niklashhh · Pull Request #121 · nix-community/gomod2nix nix-community/gomod2nix#121
Fixes #20
If the new Println is deemed unnecessary, I can remove it.