Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call templates/app/shell.nix without buildGoApplication #132

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Call templates/app/shell.nix without buildGoApplication #132

merged 1 commit into from
Nov 14, 2023

Conversation

zuqq
Copy link
Contributor

@zuqq zuqq commented Sep 23, 2023

After running nix flake init -t github:nix-community/gomod2nix#app, I get:

$ nix develop               
error:
       … while evaluating a branch condition

         at /nix/store/cz973qsjldbw4x7fx0rwcvhr9k645vz2-source/lib/customisation.nix:86:7:

           85|     in
           86|       if builtins.isAttrs result then
             |       ^
           87|         result // {

       … while calling the 'isAttrs' builtin

         at /nix/store/cz973qsjldbw4x7fx0rwcvhr9k645vz2-source/lib/customisation.nix:86:10:

           85|     in
           86|       if builtins.isAttrs result then
             |          ^
           87|         result // {

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: function 'anonymous lambda' called with unexpected argument 'buildGoApplication'

       at /nix/store/r3n8i1plbj7jfns97b73ckm5rh40x7s5-source/shell.nix:1:1:

            1| { pkgs ? (
             | ^
            2|     let

Indeed, templates/app/shell.nix has no buildGoApplication parameter:

{ pkgs ? (
let
inherit (builtins) fetchTree fromJSON readFile;
inherit ((fromJSON (readFile ./flake.lock)).nodes) nixpkgs gomod2nix;
in
import (fetchTree nixpkgs.locked) {
overlays = [
(import "${fetchTree gomod2nix.locked}/overlay.nix")
];
}
)
, mkGoEnv ? pkgs.mkGoEnv
, gomod2nix ? pkgs.gomod2nix
}:

@zuqq
Copy link
Contributor Author

zuqq commented Sep 28, 2023

@Mic92 If you get a chance, could you please review this PR?

@dezren39
Copy link

dezren39 commented Oct 16, 2023

this is my current blocker following the basic guide for getting started. it'd be nice if this could be resolved, i will try and use this feature branch for now

nix flake init -t github:zuqq/gomod2nix/fix-nix-develop#app

@Mic92 Mic92 merged commit b7d333c into nix-community:master Nov 14, 2023
@zuqq zuqq deleted the fix-nix-develop branch November 14, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants