Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

senpai: switch to scfg format #4650

Merged

Conversation

patwid
Copy link
Contributor

@patwid patwid commented Nov 12, 2023

Description

Switch to SCFG format for the configuration file following an upstream change. Supersedes #4086. Closes #2534.

Related to #4614.

Change is not backwards compatible because upstream renamed (nick -> nickname, addr -> address) and depreceted (no-tls) options.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

Maintainer CC

@malte-v @ncfavier @jleightcap

@patwid patwid force-pushed the feat/senpai-switch-to-scfg-format branch from 2366926 to 89d6922 Compare November 12, 2023 12:23
Copy link

@jleightcap jleightcap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@patwid patwid force-pushed the feat/senpai-switch-to-scfg-format branch 4 times, most recently from ac629c2 to 91f508a Compare November 13, 2023 19:38
@patwid
Copy link
Contributor Author

patwid commented Nov 13, 2023

Is there a way to prevent ./format from replacing the reserved character "\t" with actual whitespace, i.e. " " or " "?

@jleightcap
Copy link

Is there a way to prevent ./format from replacing the reserved character "\t" with actual whitespace, i.e. " " or " "?

Adding the path to the excludes, with a comment for rationale, is one possibility: https://github.com/nix-community/home-manager/blob/master/format#L28-L38

It doesn't seem possible to change the behavior of nixfmt with inline comments, unfortunately.

@patwid patwid force-pushed the feat/senpai-switch-to-scfg-format branch from 91f508a to 187027f Compare November 15, 2023 17:48
Copy link

stale bot commented Feb 14, 2024

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@stale stale bot added the status: stale label Feb 14, 2024
@rycee rycee force-pushed the feat/senpai-switch-to-scfg-format branch from 187027f to bb208b1 Compare March 15, 2024 09:31
@stale stale bot removed the status: stale label Mar 15, 2024
@rycee rycee force-pushed the feat/senpai-switch-to-scfg-format branch from bb208b1 to ca92225 Compare March 15, 2024 10:45
@rycee rycee merged commit ca92225 into nix-community:master Mar 15, 2024
3 checks passed
@rycee
Copy link
Member

rycee commented Mar 15, 2024

Thanks! Merged to master now 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: senpai new config format
3 participants