-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
senpai: switch to scfg format #4650
senpai: switch to scfg format #4650
Conversation
2366926
to
89d6922
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
ac629c2
to
91f508a
Compare
Is there a way to prevent |
Adding the path to the It doesn't seem possible to change the behavior of |
91f508a
to
187027f
Compare
Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting. If you are the original author of the PR
If you are not the original author of the PR
|
187027f
to
bb208b1
Compare
bb208b1
to
ca92225
Compare
Thanks! Merged to master now 🙂 |
Description
Switch to SCFG format for the configuration file following an upstream change. Supersedes #4086. Closes #2534.
Related to #4614.
Change is not backwards compatible because upstream renamed (nick -> nickname, addr -> address) and depreceted (no-tls) options.
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
Maintainer CC
@malte-v @ncfavier @jleightcap