Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nh: add module #5304

Merged
merged 1 commit into from
Oct 20, 2024
Merged

nh: add module #5304

merged 1 commit into from
Oct 20, 2024

Conversation

JohnRTitor
Copy link
Contributor

@JohnRTitor JohnRTitor commented Apr 19, 2024

Description

nh is a Nix CLI helper designed to provide beautiful outputs when rebuilding system or garbage collecting. Module already exists for NixOS, and so should for home manager too.

This PR

  • adds programs.nh option
  • Add nh to news
  • Add johnrtitor as maintainer

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

initial PR, I'll be maintaining this HM module

@JohnRTitor JohnRTitor force-pushed the nh-module branch 2 times, most recently from fe38e36 to 11b0c04 Compare April 19, 2024 19:06
@JohnRTitor
Copy link
Contributor Author

JohnRTitor commented Apr 19, 2024

Note: this home manager module can also run garbage collection systemd service. However it is only limited to user scope, unlike its NixOS sibling module.

modules/programs/nh.nix Outdated Show resolved Hide resolved
modules/lib/maintainers.nix Outdated Show resolved Hide resolved
modules/programs/nh.nix Outdated Show resolved Hide resolved
@rycee
Copy link
Member

rycee commented Apr 21, 2024

Thanks for the contribution! I've added a few comments.

@JohnRTitor JohnRTitor force-pushed the nh-module branch 2 times, most recently from c51cfc3 to 9b1f794 Compare April 23, 2024 17:52
@JohnRTitor JohnRTitor force-pushed the nh-module branch 2 times, most recently from 469cb49 to f7f8601 Compare July 26, 2024 13:52
@JohnRTitor
Copy link
Contributor Author

CC @teto
the tests failure seems unrelated to this module

@rycee rycee force-pushed the nh-module branch 2 times, most recently from 2e90a24 to f8b626a Compare October 20, 2024 08:06
@rycee rycee merged commit 892a644 into nix-community:master Oct 20, 2024
2 of 3 checks passed
@rycee
Copy link
Member

rycee commented Oct 20, 2024

Thanks! Merged to master now 🙂

@JohnRTitor JohnRTitor deleted the nh-module branch October 20, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants