Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zellij: add fish completions & autostart options #5333

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tennox
Copy link
Contributor

@tennox tennox commented Apr 24, 2024

Description

First, I just wanted to add completions to the fish integration, then I figured I often want completions but not autostart, then I added the autostart options listed in zellij docs, and finally adapted the tests.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@mainrs

@tennox tennox force-pushed the zellij-completions branch 2 times, most recently from e95a5f5 to 716961c Compare April 24, 2024 14:15
Copy link

stale bot commented Jul 26, 2024

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@stale stale bot added the status: stale label Jul 26, 2024
Copy link
Contributor

@mainrs mainrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rycee Is the change request correct regarding shell completions? Always enable them, since they are only added if the shell is used anyway.

// {
default = false;
};
enableFishCompletions = mkEnableOption "load zellij completions" // {
default = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These completion options should be true by default. This is true for all shells afaik.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. changed :)

default = false;
};
autoStartExitShellOnZellijExit = mkEnableOption
"When zellij exits, exit the shell as well. (requires enableFishAutoStart)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkEnableOption uses a default description text template of the form Whether to <your string you pass>. It would be great if you can adapt your text so that the whole sentence makes sense.

Or you can simply rely on mkOption with a bool type instead. And fully customize the description text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also good call - updated all descriptions :)

Copy link

stale bot commented Oct 30, 2024

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@tennox tennox force-pushed the zellij-completions branch from dbfa888 to f1434d4 Compare December 16, 2024 11:51
@tennox tennox requested a review from mainrs December 16, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants