-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zellij: add fish completions & autostart options #5333
base: master
Are you sure you want to change the base?
Conversation
e95a5f5
to
716961c
Compare
Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting. If you are the original author of the PR
If you are not the original author of the PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rycee Is the change request correct regarding shell completions? Always enable them, since they are only added if the shell is used anyway.
modules/programs/zellij.nix
Outdated
// { | ||
default = false; | ||
}; | ||
enableFishCompletions = mkEnableOption "load zellij completions" // { | ||
default = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These completion options should be true by default. This is true for all shells afaik.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. changed :)
modules/programs/zellij.nix
Outdated
default = false; | ||
}; | ||
autoStartExitShellOnZellijExit = mkEnableOption | ||
"When zellij exits, exit the shell as well. (requires enableFishAutoStart)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mkEnableOption uses a default description text template of the form Whether to <your string you pass>
. It would be great if you can adapt your text so that the whole sentence makes sense.
Or you can simply rely on mkOption
with a bool type instead. And fully customize the description text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also good call - updated all descriptions :)
Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting. If you are the original author of the PR
If you are not the original author of the PR
|
716961c
to
dbfa888
Compare
dbfa888
to
f1434d4
Compare
Description
First, I just wanted to add completions to the fish integration, then I figured I often want completions but not autostart, then I added the autostart options listed in zellij docs, and finally adapted the tests.
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@mainrs