Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dunst: only use -config flag when configFile is set #5710

Merged
merged 1 commit into from
Aug 6, 2024
Merged

dunst: only use -config flag when configFile is set #5710

merged 1 commit into from
Aug 6, 2024

Conversation

Anomalocaridid
Copy link
Contributor

Description

This ensures that in dunst's systemd service, the -config flag is only used when configFile is set. This is because when passing -config to dunst, dunst does not look for config files other than the specified path. This breaks dunst's drop-in functionality, where files can be placed in ~/.config/dunst/dunstrc.d to override settings in ~/.config/dunst/dunstrc.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@rycee

@rycee rycee merged commit a6c7439 into nix-community:master Aug 6, 2024
2 of 3 checks passed
@Anomalocaridid Anomalocaridid deleted the dunst-config-file-fix branch August 6, 2024 18:30
@rycee
Copy link
Member

rycee commented Aug 6, 2024

Thanks for the contribution!

@Anomalocaridid
Copy link
Contributor Author

It was my pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants