bash: Make sure HISTFILE's directory exists #6309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamienCassou
force-pushed
the
mkdir-histfile-directory
branch
from
50f55ee to
35aaba5
Compare
rycee
reviewed
Jan 25, 2025
DamienCassou
force-pushed
the
mkdir-histfile-directory
branch
2 times, most recently
from
40afd1b to
9c063b0
Compare
Co-authored-by: Robert Helgesson <robert@rycee.net>
DamienCassou
force-pushed
the
mkdir-histfile-directory
branch
from
9c063b0 to
26651d1
Compare
|
Thank you for the feedback. I applied your changes. |
|
Sorry about the delay. Merged to master now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If HISTFILE's directory doesn't exist, bash history doesn't work. This PR fixes this.
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC