Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/common: forward nix.enable from the OS configuration #6383

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emilazy
Copy link
Contributor

@emilazy emilazy commented Jan 30, 2025

Description

This prevents problematic references to nix.package when Nix management is disabled in the host OS.

Drafted until the corresponding nix.enable functionality is merged into nix-darwin, since this is probably more useful there than on NixOS.


Note: This work was funded by Determinate Systems. The design is my own.

Checklist

  • Change is backwards compatible. (‐ish; you could theoretically be relying on the host OS’s nix.package when nix.enable is turned off, but that sounds unwise…)

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example. (it doesn’t seem like there are any existing tests for nix.enable, so not sure where to add this)

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@rycee

This prevents problematic references to `nix.package` when Nix
management is disabled in the host OS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant