-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hydra: switch to fork #1349
hydra: switch to fork #1349
Conversation
18be010
to
27a6100
Compare
0a45323
to
d8c0264
Compare
@@ -24,6 +24,8 @@ | |||
flake-compat.url = "github:nix-community/flake-compat"; | |||
flake-parts.inputs.nixpkgs-lib.follows = "nixpkgs"; | |||
flake-parts.url = "github:hercules-ci/flake-parts"; | |||
hydra.flake = false; | |||
hydra.url = "github:qowoz/hydra/community"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just ask for commit access and get those commits in upstream?
We can probably even test them on the actual NixOS hydra, the current infra team is looking for help anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost all of them have been deployed on hydra.nixos.org for a while and are in various upstream branches / PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zowoq even more a reason to just merge them into the hydra branch. I ask for access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also looking at picking the lix patches that replace hydra-eval-jobs with nix-eval-jobs. Would need to pick a couple their patches for nix-eval-jobs as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zowoq if I would look at this, would you be ok, if we run the result on nix-community infra?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to pick patches from a upstream PR if that is what you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, I would need to test patches as well in a non-trivial setup and do fixes as needed. Local testing of demo instances only take you so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For that I'd suggest deploying another hydra instance on build01.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping we could test hydra changes together, but in that case I could also look for a different project where I can deploy a hydra.
f389f22
to
328820b
Compare
I've deployed the patches for this: GHSA-xv29-v93r-2f5v. |
this is the default but we need to set it explictly as it is currently broken upstream and in nixpkgs
Manually deployed on build03 for testing.