Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform/hydra-projects: add unfree #1406

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

terraform/hydra-projects: add unfree #1406

wants to merge 1 commit into from

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 7, 2024

No description provided.

@zowoq zowoq marked this pull request as draft August 7, 2024 23:28
flake_uri = "https://github.com/numtide/nixpkgs-unfree/nixpkgs-unstable"

check_interval = 1800
scheduling_shares = 5000
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 1000 less than cuda/rocm have.

Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

terraform/hydra-projects.tf Outdated Show resolved Hide resolved
@zowoq
Copy link
Contributor Author

zowoq commented Aug 9, 2024

https://hydra.nix-community.org/jobset/nixpkgs/unfree

@zowoq
Copy link
Contributor Author

zowoq commented Aug 26, 2024

https://hydra.nix-community.org/eval/28213#tabs-removed

requireFile is probably about as far as filtering can go, anything further needs to be done by updating the packages in nixpkgs:

NixOS/nixpkgs#335271
https://hydra.nix-community.org/eval/33493#tabs-removed


I think the relevant parts of numtide/nixpkgs-unfree can upstreamed to nixpkgs but what I want to do is keep the current filters as the default version that we can keep building frequently and a "full" version behind an option that can be used for the code coverage job but on a slower channel, built less frequently and at a lower priority than the other hydra jobsets.

e.g.

  default = isUnfree && isSource && isNotCudaPackage && isNotLinuxKernel && canSubstituteSrc;

  full = isUnfree && isSource && canSubstituteSrc;
resource "hydra_jobset" "nixpkgs_unfree_full" {
  nix_expression {
    file  = "pkgs/top-level/release-unfree.nix"
    input = "nixpkgs"
  }

  input {
    name              = "full"
    type              = "boolean"
    value             = "true"
  }

  input {
    name              = "nixpkgs"
    type              = "git"
    value             = "https://github.com/NixOS/nixpkgs.git nixos-unstable"
  }

  check_interval    = ? # once a week
  scheduling_shares = 1000
}

@zowoq
Copy link
Contributor Author

zowoq commented Sep 4, 2024

@zimbatm have you seen my previous comment here?

@zowoq zowoq closed this Sep 13, 2024
@zowoq zowoq deleted the unfree branch September 13, 2024 01:17
@zowoq zowoq restored the unfree branch September 13, 2024 01:34
@zowoq
Copy link
Contributor Author

zowoq commented Sep 13, 2024

@zimbatm are you going to upstream this?

@zowoq zowoq reopened this Sep 13, 2024
@zimbatm
Copy link
Member

zimbatm commented Sep 13, 2024

will do 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants