project: move to nixpkgs Rust infrastructure

[RaitoBezarius]

This builds the stub and tool using rustPlatform.buildRustPackage which features a stable Rust compiler, recent enough to support UEFI targets.

In the future, it will rely on properly defined targets for UEFI in nixpkgs. : we won't need it.

For now, this PR is broken and depends on various changes in nixpkgs upstream for proper "cross compilation" support for UEFI targets, see NixOS/nixpkgs#226145 for example.

Closes #98.

[RaitoBezarius]

This is ready for the initial review phase, final todolist:

• bring back rustfmt validation: @nikstur can you help me here?
• remove x86_64 hardcoding

[RaitoBezarius]

Once we merge this, we can probably start upstreaming stable versions of Lanzaboote into nixpkgs.

[nikstur]

Looks good, would really love to keep cargp fmt as a buildable derivation for nix flake check though.

[alyssais]

I'd use overrideAttrs for clippy and rustfmt rather than flags and merging in the main derivation expression. That way they could even live in separate files if you wanted.

[alyssais]

Did we actually get building for aarch64 to work?

[RaitoBezarius]

error: Package ‘compiler-rt-14.0.6’ in /nix/store/wr7rzhqpb71986npaa2fvbjg302yb3r7-source/pkgs/development/compilers/llvm/14/compiler-rt/default.nix:128 is not available on the requested hostPlatform:

but passing the classical "unsupported systems ok" flag yields you

❯ llvm-objdump --section-headers /nix/store/xfjgpsn98yw3i0bc071zdk4606ij10bg-lanzastub-aarch64-windows-0.3.0/bin/lanzaboote_stub.efi 

/nix/store/xfjgpsn98yw3i0bc071zdk4606ij10bg-lanzastub-aarch64-windows-0.3.0/bin/lanzaboote_stub.efi:	file format coff-arm64

Sections:
Idx Name          Size     VMA              Type
  0 .text         00014770 0000000140001000 TEXT
  1 .rdata        000047f0 0000000140016000 DATA
  2 .data         00000070 000000014001b000 DATA
  3 .reloc        000003a8 000000014001c000 DATA

on a native aarch64 machine

[alyssais]

Yes, it wasn't a question whether it would build, but whether it would boot.

Remember the discussion about how aarch64 UEFI is not the same as aarch64 Windows that caused the argument over triples in the first place.

[RaitoBezarius]

Unfortunately, testing until the end requires some support in systemd which is only on the main branch at the moment.

[RaitoBezarius]

@nikstur can you make it so that the project compiles with all the features? right now we have mutually exclusive features which prevent me from doing cargo clippy --all-features :-[

[nikstur]

@nikstur can you make it so that the project compiles with all the features? right now we have mutually exclusive features which prevent me from doing cargo clippy --all-features :-[

This is not possible in the current setup because the features are semantically exclusive. If we want to compile with all feature we would need to creare two separate binaries.

[RaitoBezarius]

I see, then, no problem, I will find a way :-) Le sam. 10 juin 2023 à 14:31, nikstur ***@***.***> a écrit :

…

@nikstur <https://github.com/nikstur> can you make it so that the project compiles with all the features? right now we have mutually exclusive features which prevent me from doing cargo clippy --all-features :-[ This is not possible in the current setup because the features are semantically exclusive. If we want to compile with all feature we would need to creare two separate binaries. — Reply to this email directly, view it on GitHub <#147 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACMZRFDAKJDA5ZYBFPARF3XKRSIPANCNFSM6AAAAAAW6MPCMY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[nikstur]

There are a few opportunities to minimize the diff but this is good to go. Thanks for the effort!

[SuperSandro2000]

Suggested change

	config = "${pkgs.hostPlatform.qemuArch}-windows";
	rustc.config = "${pkgs.hostPlatform.qemuArch}-unknown-uefi";
	config = "${pkgs.stdenv.hostPlatform.qemuArch}-windows";
	rustc.config = "${pkgs.stdenv.hostPlatform.qemuArch}-unknown-uefi";

       error: attribute 'hostPlatform' missing

       at /nix/store/k7h8k8whqw64rmsg6yhkmmdc82lkczc6-source/flake.nix:66:27:

           65|               # linuxArch is wrong here, it will yield arm64 instead of aarch64.
           66|               config = "${pkgs.hostPlatform.qemuArch}-windows";
             |                           ^
           67|               rustc.config = "${pkgs.hostPlatform.qemuArch}-unknown-uefi";
       Did you mean rustPlatform?

Going to test this and create a PR.

[SuperSandro2000]

see #198