Remove Nondeterminism in Stub #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linker embeds a timestamp into our UEFI stub. objdump -p reports: Time/Date Mon Nov 13 20:02:35 2023 With /Brepro we get the following instead: Time/Date d597e888 (This is a reproducible build file hash, not a timestamp) Fixes #260
| @@ -1,2 +1,4 @@ | |||
| [build] | |||
| target = "x86_64-unknown-uefi" | |||
| # Strip timestamps from binaries. | |||
| rustflags = ["-C", "link-args=/Brepro"] | |||
There was a problem hiding this comment.
damn, I was so close 😂 Thanks!
SuperSandro2000
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
👍🏼
/nix/store/x1qch1dlqgwzczqmx1wxh3ssr2ya6fsl-lanzaboote-stub-0.3.0/bin/lanzaboote_stub.efi: file format pei-x86-64
Characteristics 0x22e
executable
line numbers stripped
symbols stripped
large address aware
debugging information removed
Time/Date 7d8622be (This is a reproducible build file hash, not a timestamp)
Magic 020b (PE32+)
MajorLinkerVersion 14
MinorLinkerVersion 0
SizeOfCode 0000000000016800
SizeOfInitializedData 0000000000005800
SizeOfUninitializedData 0000000000000000
AddressOfEntryPoint 000000000000ddac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linker embeds a timestamp into our UEFI stub. objdump -p reports:
With
/Breprowe get the following instead:Fixes #260