Improve gc op #123
Open
Improve gc op #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profpatsch
force-pushed
the
improve-gc-op
branch
2 times, most recently
from
4f85336
to
aa08312
Compare
It’s just a better environment that way … sigh
Instead of having complex generic types internally that we map over, just create the json in a macro. Removes `ProjectAdded` from `Reason`, because it was not used anywhere. Changes the daemon format, so make sure to run the daemon with this new lorri version or you get serialization errors.
This new function makes it easy to race two threads, instead of syncing on shared state. This also simplifies the duration code, since all we are doing is waiting on timeouts and the stop channel.
Instead of using serde, defining a clear API boundary (preventing breakage on refactors).
We only pass the `cas` through the `Project` constructor, never actually using it in the project `impl`!. This means we don’t need to burden `Project` with the cas, since it’s only used by the builder in the end. Insead, put it on the build loop for now. Funnily enough, `StartUserShell` does not need the project init anymore, cause it only wanted the `cas` from it.
Collect errors and continue deleting when json is not on.
Profpatsch
force-pushed
the
improve-gc-op
branch
from
aa08312
to
e001762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release.nix(seerelease.nixfor instructions)