Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR replace
structopt
with the latestclap
version. For now it's building and all the test are passing usingcargo build
andcargo test
, but when I try to runnix-build
theclap_lex
crate fail to build with the following error:clap has a MSRV set at
1.74.0
, and those functions were added in rust1.74.0
so this should work since nixos24.05
is using rust1.77.2
.I think it's mainly a lack of nix experience and skill here. @nyarly if you have a couple of minutes, could you tell me if the rust version used to build this project is pinned to something older then
1.74.0
, and or what would be the way to know which version of rustnix-build
is using?EDIT: I found it,
nixpkgs
were still pinned to23.11
. I updatenix/update-nixpkgs.sh
and run it. Now it builds 🎉Fixes #105
release.nix
(seerelease.nix
for instructions)