-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo.toml: Git Dependencies #149
Comments
I have a similiar issue. Those are the commands it tries to execute in this case:
The fetch command fails in a reproducible way:
|
This reverts commit 79129b5. This fixes nix-community#149
Thank you! This fixed the part of:
But sadly I seem to have a similar Issue with:
If anyone has a similar issue. I am just patching the Cargo.toml file for now. Ruma has main as a default branch, and if I specify it in the Cargo.toml everything works. |
Yes. Different default branches are still a problem. The commit that was reverted tried to solve this, but broke the general case. |
I'm also trying to build a project (conduit) which has a dependency on ruma using naersk. It's failing for the same main-branch related reason. However, I'm unable to add Do you have any ideas for how to address this? (Sorry for resurrecting a closed thread and thanks for the awesome lib!) |
@jcarrag, |
this allows us to avoid issues when the default branch is not named `master`. I believe this should fix the issues described in: nix-community#149 nix-community#140 using this change seems to fix this error I was seeing: ``` fetching Git repository 'https://github.com/sacredcapital/rep_lang.git'fatal: couldn't find remote ref refs/heads/master error: program 'git' failed with exit code 128 ``` and enables a successful build. I reproduced the successful build on multiple machines. however I cannot be full certain that it works in all cases. additionally, it seems possible that `allRefs = true` causes annoying extra fetching which might be noticeable for repos with many refs...
this allows us to avoid issues when the default branch is not named `master`. I believe this should fix the issues described in: nix-community#149 nix-community#140 using this change seems to fix this error I was seeing: ``` fetching Git repository 'https://github.com/sacredcapital/rep_lang.git'fatal: couldn't find remote ref refs/heads/master error: program 'git' failed with exit code 128 ``` and enables a successful build. I reproduced the successful build on multiple machines. however I cannot be full certain that it works in all cases. additionally, it seems possible that `allRefs = true` causes annoying extra fetching which might be noticeable for repos with many refs...
When I try to build a package with this in the Cargo.toml:
I get this error message:
But the rev seems to exist.
If you want I can also attach the --show-trace.
The text was updated successfully, but these errors were encountered: