Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use the revision from Cargo.lock #137

Merged
merged 2 commits into from
Jan 18, 2021

Conversation

yusdacra
Copy link
Member

@yusdacra yusdacra commented Jan 4, 2021

This should fix #109 I believe. I'm not quite sure of the code, especially the matchByName function, but it works perfectly on one of my projects and also passes the tests.

@yusdacra yusdacra requested a review from nmattia as a code owner January 4, 2021 21:13
@yusdacra yusdacra marked this pull request as draft January 4, 2021 21:20
@yusdacra yusdacra force-pushed the extract-rev-cargolock branch 5 times, most recently from ea6ee88 to a70e790 Compare January 4, 2021 22:32
@yusdacra yusdacra marked this pull request as ready for review January 4, 2021 22:43
Copy link
Collaborator

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you very much! Just got one question.

lib.nix Outdated Show resolved Hide resolved
Copy link
Collaborator

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for addressing the comment!

@nmattia nmattia merged commit 79a613f into nix-community:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No rev specified
2 participants