force fetchGit allRefs when a dependency is specified with "rev" #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage of git "rev" dependencies in Cargo implies that the rev
will be found regardless of ref. This is currently not true in naersk;
the following dependency fails:
usbfs = {git = "https://github.com/goertzenator/usbfs-rs", rev = "7c35b46e41ad76f838cd99b493f9337f475b5b70"}
goertzenator
requested review from
Patryk27,
nmattia,
Anderssorby and
blitz
as code owners
|
Hi 🙂 Thanks for this pull request; we've already considered doing that in the past (#211), but eventually settled on a dedicated option, because I see NixOS 22.05 ships with Nix 2.8 and https://nixos.org/download.html provides Nix 2.9, so I think it's time to revisit that decision - but, just in case, could you introduce a version check there? (something like https://github.com/nix-community/poetry2nix/blob/57b1515c0b053eece543605414ebb104e39c247a/mk-poetry-dep.nix#L174 should do it) |
|
whoopsie, missclick! |
|
Thanks for the response. I will add the suggested change in the next few days. |
|
Additional reference information on this topic: NixOS/nix#5128 |
Prevent use of allRefs when nix <2.4 is in use. nix <2.4 does not accept the `allRefs` flag, but has `allRefs` behavior by default. Note that this goes beyond the the initial intent of this PR because it enables naersk's `gitAllRefs` flag to work on nix <2.4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of git "rev" dependencies in Cargo implies that the rev
will be found regardless of ref. This is currently not true in naersk;
the following dependency fails:
usbfs = {git = "https://github.com/goertzenator/usbfs-rs", rev = "7c35b46e41ad76f838cd99b493f9337f475b5b70"}