flakes: Don't run shellHook on cached dev shells #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jun 8, 2021
direnvrc
Outdated
| @@ -135,6 +135,7 @@ use_flake() { | |||
|
|
|||
| log_status renewed cache | |||
| else | |||
| sed -i '/eval \"\$shellHook\"/d' "$profile_rc" | |||
There was a problem hiding this comment.
Can it be not substituted once when it is cached?
There was a problem hiding this comment.
okay. maybe not worth the complexity.
|
shellcheck is a bit unhappy, otherwise ok. |
This makes the behavior of `use flake` consistent with that of `use nix`. Resolve nix-community#90.
ryneeverett
force-pushed
the
shellhook-caching
branch
from
7b86b7f to
6e68ea7
Compare
|
CI should pass now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the behavior of
use flakeconsistent with that ofuse nix.Resolve #90.