host lookup simplifications and refactorings #2

flokli · 2022-11-11T21:43:01Z

We don't have to use a lambda to return a value from a sub-expression. Rust takes the last value in a scope as return value even if it isn't a function.

The function belongs to the data format and not to the actual processing logic. This isn't a clean cut just yet all over the codebase but moving this very fragile piece into its own function will enable us to test it in isolation.

This makes the result filtering similar and thus should be less confusing.

This is as efficient as doing the manual pre-allocation as the `to_vec` method will use the length of the slice for the initial size allocation of the vector.

Previously this would produce a malformed packet as far as glibc is concerned. If there are no addresses the "found" field should not be one and the other lookup fields can also be left blank.

This moves the "well-known" wire format structs to constants that can be reused without having to duplicate their definition all the time.

andir added 7 commits November 11, 2022 21:38

Remove useless lambda and lambda call in serialize_host

164f831

We don't have to use a lambda to return a value from a sub-expression. Rust takes the last value in a scope as return value even if it isn't a function.

Move the host serialize code to a associated function

56a0a21

The function belongs to the data format and not to the actual processing logic. This isn't a clean cut just yet all over the codebase but moving this very fragile piece into its own function will enable us to test it in isolation.

Make the GETHOSTBYNAMEv6 handling similar to the v4 equivalent

d9f3bb1

This makes the result filtering similar and thus should be less confusing.

Use as_slice().to_vec() instead of manually pre-allocated buffers

b2f73c7

This is as efficient as doing the manual pre-allocation as the `to_vec` method will use the length of the slice for the initial size allocation of the vector.

Make Host::serialize able to serialize empty address lists

5c2f843

Previously this would produce a malformed packet as far as glibc is concerned. If there are no addresses the "found" field should not be one and the other lookup fields can also be left blank.

Move common HostResponseHeader to const structs

092cab9

This moves the "well-known" wire format structs to constants that can be reused without having to duplicate their definition all the time.

Simplify the serialize_host nested Result<Some<Option<..>> handling

5832ab3

picnoir approved these changes Nov 14, 2022

View reviewed changes

flokli merged commit 47e580f into host-lookups Nov 14, 2022

flokli deleted the andir-fixes branch November 14, 2022 09:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

host lookup simplifications and refactorings #2

host lookup simplifications and refactorings #2

flokli commented Nov 11, 2022

host lookup simplifications and refactorings #2

host lookup simplifications and refactorings #2

Conversation

flokli commented Nov 11, 2022