Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application-title-bar widget-specific options #234

Merged

Conversation

HeitorAugustoLN
Copy link
Member

Implements third-party widget-specific options for application-title-bar as suggested in #229

@magnouvean
Copy link
Collaborator

Other than that it looks OK for the most part I reckon. I don't really have time to test all these options though, but maybe I'll test a few of them tomorrow and see if they generally work. In the future we should maybe also add an option to add the widget automatically to extraWidgets, but the interface isn't really there yet so that can be done in another pr.

@HeitorAugustoLN
Copy link
Member Author

Other than that it looks OK for the most part I reckon. I don't really have time to test all these options though, but maybe I'll test a few of them tomorrow and see if they generally work.

As far as I tested, everything should be working right now.

In the future we should maybe also add an option to add the widget automatically to extraWidgets, but the interface isn't really there yet so that can be done in another pr.

That is a good idea, I could try doing it later.

@magnouvean
Copy link
Collaborator

Nice that has done the trick. I'll merge right away then as this looks good. Great work!

@magnouvean magnouvean merged commit 121424d into nix-community:trunk Jun 29, 2024
1 check passed
@HeitorAugustoLN
Copy link
Member Author

Thanks!

@HeitorAugustoLN HeitorAugustoLN deleted the application-title-bar-options branch June 29, 2024 22:57
toast003 pushed a commit to toast003/plasma-manager that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants