Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change powerdevil.*.idleTimeOut to idleTimeout to maintain consistency #366

Merged
merged 1 commit into from
Sep 21, 2024
Merged

change powerdevil.*.idleTimeOut to idleTimeout to maintain consistency #366

merged 1 commit into from
Sep 21, 2024

Conversation

meirisoda
Copy link
Contributor

I noticed that the option for

programs.plasma.powerdevil = {
    AC.idleTimeOut 
    battery.idleTimeOut
};

uses TimeOut instead of Timeout like every other timeout option in powerdevil. This is not consistent with the rest of powerdevil and may cause confusion (as it did with me).

@HeitorAugustoLN HeitorAugustoLN added 0. type: enhancement New feature or request for feature 1. scope: powerdevil Related to powerdevil module 5. first time contribution 4. has: plasma module (update) Updates plasma module labels Sep 21, 2024
HeitorAugustoLN
HeitorAugustoLN approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@HeitorAugustoLN HeitorAugustoLN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot! Thanks for your contribution :)

@HeitorAugustoLN HeitorAugustoLN merged commit 7fb80fe into nix-community:trunk Sep 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeitorAugustoLN HeitorAugustoLN HeitorAugustoLN approved these changes

Assignees
No one assigned
Labels
0. type: enhancement New feature or request for feature 1. scope: powerdevil Related to powerdevil module 4. has: plasma module (update) Updates plasma module 5. approvals: 1 5. first time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meirisoda @HeitorAugustoLN