-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add per-widget customization options #59
Conversation
I'll review this tomorrow morning, it's late and I'm very tired
Jan 22, 2024, 12:26 AM by ***@***.***:
…
@magnouvean <https://github.com/magnouvean>> requested your review on: > #59 <#59>> Add per-widget customization options.
—
Reply to this email directly, > view it on GitHub <#59 (comment)>> , or > unsubscribe <https://github.com/notifications/unsubscribe-auth/AJJUMAQTVN6NRSCMJPSPHE3YPWPBBAVCNFSM6AAAAABCEKPSNSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGU2TAMRRG4YTSNY>> .
You are receiving this because your review was requested.> Message ID: > <pjones/plasma-manager/pull/59/issue_event/11550217197> @> github> .> com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
Let me test it rn and I'll approve it after
All good! I did see some typos on the defaults for the widgets, but that belongs in a different pr (which I'll do later) |
Good I'll merge this right away then :) |
panel works on kde 5, but it doesn't work on coming kde 6 |
How did you test plasma 6 @mlyxshi ? Can't promise anything but if it's not working for something simple I could fix it if I find out how to get plasma 6 on NixOS |
Works brilliantly! Thanks |
Test kde 6 in virtual machine as standalone home-manager config |
Added an option to add widgets with additional configuration options. Tested on my basic config and it works great! Removed also
iconTasksLaunchers
as this should now be configured. The syntax is implemented as the following:To set the launchers for
icontasks
you can for example use:Do note that this solution supports both lists and strings as values, and should work as what you expect with both of these. To add nested configgroups where that may be needed you can use period in the group name, for example
"Group1.Group2.Group3".key = value;
Would be great if someone could test that this works (by setting https://github.com/magnouvean/plasma-manager as the flake url) for their configuration in order to confirm that this works for the required needs. Should close #56