Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per-widget customization options #59

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Add per-widget customization options #59

merged 2 commits into from
Jan 22, 2024

Conversation

magnouvean
Copy link
Collaborator

Added an option to add widgets with additional configuration options. Tested on my basic config and it works great! Removed also iconTasksLaunchers as this should now be configured. The syntax is implemented as the following:

{
  name = "org.kde.plasma.kickoff";
  config.General.icon = "nix-snowflake-white";
}

To set the launchers for icontasks you can for example use:

{
  name = "org.kde.plasma.icontasks";
  config = {
    General.launchers = [
      "applications:org.kde.dolphin.desktop"
      "applications:org.wezfurlong.wezterm.desktop"
      "applications:brave-browser.desktop"
    ];
  };
}

Do note that this solution supports both lists and strings as values, and should work as what you expect with both of these. To add nested configgroups where that may be needed you can use period in the group name, for example "Group1.Group2.Group3".key = value;
Would be great if someone could test that this works (by setting https://github.com/magnouvean/plasma-manager as the flake url) for their configuration in order to confirm that this works for the required needs. Should close #56

@magnouvean magnouvean requested a review from toast003 January 21, 2024 23:19
@toast003
Copy link
Collaborator

toast003 commented Jan 21, 2024 via email

Copy link
Collaborator

@toast003 toast003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

Let me test it rn and I'll approve it after

@toast003
Copy link
Collaborator

All good!

I did see some typos on the defaults for the widgets, but that belongs in a different pr (which I'll do later)

@magnouvean
Copy link
Collaborator Author

Good I'll merge this right away then :)

@magnouvean magnouvean merged commit 4d209a0 into nix-community:trunk Jan 22, 2024
@mlyxshi
Copy link
Contributor

mlyxshi commented Jan 24, 2024

panel works on kde 5, but it doesn't work on coming kde 6

@toast003
Copy link
Collaborator

How did you test plasma 6 @mlyxshi ?

Can't promise anything but if it's not working for something simple I could fix it if I find out how to get plasma 6 on NixOS

@martijnboers
Copy link

Works brilliantly! Thanks

@mlyxshi
Copy link
Contributor

mlyxshi commented Jan 24, 2024

How did you test plasma 6 @mlyxshi ?

Can't promise anything but if it's not working for something simple I could fix it if I find out how to get plasma 6 on NixOS

Test kde 6 in virtual machine as standalone home-manager config

  1. kde neon: https://neon.kde.org/download
  2. feora 40: https://dl.fedoraproject.org/pub/fedora/linux/development/rawhide/Spins/x86_64/iso/

For NixOS
https://github.com/nix-community/kde2nix

@magnouvean magnouvean mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per panel widget configuration?
4 participants