-
-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
Also pushed a temp fix for #75, while I'm not too happy about it, there isn't much else we can do about it to unblock folks on macos since it appears to be a NixOS bug. cc @lilyball @DieracDelta (would be awesome if you could test this on Darwin for me :)) |
I tested this in two ways on rev 01b3623 on my m1. This is the commit with the gc test enabled for aarch64-darwin. I believe the GC problem I was encountering got fixed shortly after I opened #71 (see Eelco's PR ). I hope this means we can keep the gc test. What I tested on: |
The disabled test isn't related to GC, it's a test that fails when Nix is configured to enable the sandbox when calling Another option is to set I suppose a third option is to make the test explicitly check if |
I successfully built rnix-lsp on my M1 machine with the I am not set up right now to easily actually test the language server itself (I haven't configured vim for that yet, and I didn't want to change my VSCode user config), but the build is the important part. |
I just did the same on my x86_64-darwin machine for good measure. |
I'm not very keen on maintaining workarounds (at several places) for a Nix bug tbh. In the end this isn't a system/architecture-specific feature, so as long as it doesn't break everywhere we should be fine IMHO. That said I'd merge this and publish a new release to fix the issue on our end at least. |
Summary & Motivation
Bump
nixpkgs
to 21.11 since 21.05 is dead. Also, thenixUnstable
from 21.05 doesn't seem to build on Darwin.Further context
see #71
cc @DieracDelta