Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darwin support #441

Merged
merged 9 commits into from
Jun 30, 2024
Merged

Darwin support #441

merged 9 commits into from
Jun 30, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 13, 2024

Now that this seems to be now also part of my own infastructure,
I kind of miss having srvos to share configuration.
Also there is some opportunity to share code with NixOS,
I decided to not do so as it would make contributing to this project harder
as not everyone has access to both Linux and MacOS at the same time.

I think it's acceptable to have a slight code drift, but allow to properly test
changes on both platforms in their own time.

I still need to update documentation here.

@zowoq
Copy link
Contributor

zowoq commented Jun 14, 2024

Also there is some opportunity to share code with NixOS, I decided to not do so

I think it's acceptable to have a slight code drift, but allow to properly test changes on both platforms in their own time.

I wanted to share code and avoid drift so this is the opposite of what I wanted to do here.

If this is what you want to do, okay, I'm not interested in debating it but I'm not going to use it for the community infra.

@Mic92 Mic92 marked this pull request as ready for review June 14, 2024 05:09
@zimbatm
Copy link
Member

zimbatm commented Jun 14, 2024

Sounds good.

To have shared code, we need CI to exercise the Darwin code first. The CI is pretty fast so I think it would be reasonable after that.

@Mic92 Mic92 force-pushed the darwin-support branch 2 times, most recently from b0ad57a to 210a632 Compare June 27, 2024 10:05
enable nix-daemon
@Mic92 Mic92 force-pushed the darwin-support branch 2 times, most recently from d076823 to 206a27f Compare June 27, 2024 10:59
@Mic92
Copy link
Member Author

Mic92 commented Jun 30, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Jun 30, 2024

queue

🛑 The pull request has been removed from the queue default

The pull request #441 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Mic92 Mic92 merged commit 22155bc into main Jun 30, 2024
98 checks passed
@Mic92 Mic92 deleted the darwin-support branch June 30, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants