Update sources #255
Merged
Update sources #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulrikstrid
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Only cachix failed with the normal issue, should be ok to merge. @anmonteiro
|
This is still not good, and has the same problems that #254 has, with the graphql-cohttp failure. I can't reproduce it locally, though |
ulrikstrid
reviewed
Apr 27, 2022
| @@ -534,6 +518,10 @@ with oself; | |||
| graphql-async = callPackage ./graphql/async.nix { }; | |||
|
|
|||
| graphql_ppx = callPackage ./graphql_ppx { }; | |||
| graphql-cohttp = osuper.graphql-cohttp.overrideAttrs (o: { | |||
| # https://github.com/NixOS/nixpkgs/pull/170664 | |||
| nativeBuildInputs = [ ocaml dune findlib crunch ]; | |||
There was a problem hiding this comment.
o.nativeBuildInputs ++ [ crunch ]
There was a problem hiding this comment.
nativeBuildInputs brings in ocaml-crunch which depends on pkgs.ocamlPackages. the version there might be different. check NixOS/nixpkgs#170664
|
seems fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:robot_face: Updating sources to the latest version.
Commits touching OCaml packages:
Diff URL: NixOS/nixpkgs@c10c891...d6b9960