Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shall safety status of unistd::fork be the same as std's Process::pre_exec? #1030

Closed
vi opened this issue Feb 14, 2019 · 5 comments · Fixed by #1293
Closed

Shall safety status of unistd::fork be the same as std's Process::pre_exec? #1030

vi opened this issue Feb 14, 2019 · 5 comments · Fixed by #1293

Comments

@vi
Copy link
Contributor

vi commented Feb 14, 2019

It is going to be made unsafe, but nix's fork seems to be still safe.
@asomers
Copy link
Member

asomers commented Feb 14, 2019

Yep, we should do the same.

@jorickert jorickert mentioned this issue Apr 23, 2019
Closed
@RalfJung
Copy link

RalfJung commented Nov 3, 2019

Indeed, fork should be marked unsafe. It even has a "safety" comment, that should never be the case of a safe function.

@vi
Copy link
Contributor Author

vi commented Sep 10, 2020

Why is it still not marked unsafe?

Is it just missing a pull request that adds unsafe to the function and unsafe { } to the tests?

@asomers
Copy link
Member

asomers commented Sep 10, 2020

Yep.

vi added a commit to vi/nix that referenced this issue Sep 10, 2020
@vi
Mark nix::unistd::fork as unsafe.
48c7419 
Fix tests. No change in documentation.

Resolves nix-rust#1030.
@vi vi mentioned this issue Sep 10, 2020
Merged
vi added a commit to vi/nix that referenced this issue Sep 10, 2020
@vi
Mark nix::unistd::fork as unsafe.
e46ce3c 
Fix tests. No change in documentation.

Resolves nix-rust#1030.
@vi
Copy link
Contributor Author

vi commented Sep 11, 2020 •
edited
Loading

@asomers, Made the pull request.

bors bot added a commit that referenced this issue Oct 3, 2020
@bors @vi
Merge #1293
8e3789d 
1293: Mark nix::unistd::fork as unsafe. r=asomers a=vi

Fix tests. No change in documentation.

Resolves #1030.

Don't forget to bump major version number to `0.19`.

Co-authored-by: Vitaly _Vi Shukela <vi0oss@gmail.com>
@bors bors bot closed this as completed in 74cb154 Oct 3, 2020
yoav-steinberg pushed a commit to yoav-steinberg/nix that referenced this issue Oct 4, 2020
@vi @yoav-steinberg
Mark nix::unistd::fork as unsafe.
11b969c 
Fix tests. No change in documentation.

Resolves nix-rust#1030.
@tjkirch tjkirch mentioned this issue Nov 5, 2020
Merged
arush-sal pushed a commit to arush-sal/greetd that referenced this issue Feb 17, 2021
@alebastr @kennylevinsen
deps: update nix and other dependencies
e5a5982 
`fork` is now marked as unsafe (nix-rust/nix#1030)
@RalfJung RalfJung mentioned this issue Apr 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark nix::unistd::fork as unsafe. vi/nix
mark fork as unsafe jorickert/nix
3 participants
@asomers @vi @RalfJung