Use #[non_exhaustive] after updating MSRV to 1.40.0 #1182
Assignees
Comments
|
For reference, as of nix 0.8.0 the current MSRV is already at 1.41.0 since #1440. |
bors bot
added a commit
that referenced
this issue
Jul 29, 2021
1473: sys/stat: add a safe wrapper for mknodat(2) r=asomers a=lucab This introduces a new `mknodat` helper. Ref: https://pubs.opengroup.org/onlinepubs/9699919799/functions/mknod.html 1474: Mark most C-derived enums as non_exhaustive r=asomers a=asomers Since libc may add new variants at any time, Nix's consumers should not use exhaustive match patterns. Fixes #1182 1476: Constify many functions r=asomers a=asomers Constify most functions that can be constified. The exceptions are mostly accessors for structs that have no const constructor. Co-authored-by: Luca BRUNO <luca.bruno@coreos.com> Co-authored-by: Alan Somers <asomers@gmail.com>
LMJW
pushed a commit
to LMJW/nix
that referenced
this issue
Jul 31, 2021
Since libc may add new variants at any time, Nix's consumers should not use exhaustive match patterns. Fixes nix-rust#1182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
#[non_exhaustive]attribute, introduced by Rust 1.40.0, should be used for most enums that come from C, since new values could be added by any release. This attribute isn't valuable enough to justify a MSRV bump by itself. But we should still make use of it whenever we update the MSRV for any other reason.The text was updated successfully, but these errors were encountered: