File descriptor not closed in TimerFd #1379
Comments
|
Good catch! Would you be willing to submit a PR to fix it? |
|
I'll do that shortly. |
bors bot
added a commit
that referenced
this issue
Feb 20, 2021
1381: Close file descriptor on drop in TimerFd r=asomers a=crdumoul This change closes the TimerFd file descriptor on drop. Note that the TimerFd will no longer be `Clone` or `Copy`. Since it has a destructor it can't be `Copy`, and if it were `Clone` you could end up trying to use a closed TimerFd, or double-closing the file descriptor. Addresses #1379. Co-authored-by: Christopher Dumoulin <cdumouli@akamai.com> Co-authored-by: Alan Somers <asomers@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As specified in https://man7.org/linux/man-pages/man2/timerfd_create.2.html the file descriptor for a timerfd should be closed when it is no longer required. In
nix::sys::timerfd::TimerFdthere is noDropimplementation and the file descriptor is not automatically closed. This leads to a file descriptor leak.The
TimerFdstruct either needs to properly own the file descriptor and close it when it's dropped, or make it explicit through documentation that the user ofTimerFdneeds to close the file descriptor themselves.The text was updated successfully, but these errors were encountered: