You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The fs type constants defined in src/sys/statfs are guard by #[cfg(all(target_os = "linux", not(target_env = "musl")))] and therefore not available for target_os = "android. That hit me while patching cgroups-rs for Android and adding the target_os = "android" guard here
Any change to get this updated to #[cfg(any(all(target_os = "linux", not(target_env = "musl")), target_os = "android"))]?
If yes I can prepare a PR.
Thanks!
The text was updated successfully, but these errors were encountered:
It depends. Are those constants actually defined on Android? If they are, are they defined in rust's libc? If the answer to the first question is "no", then there's nothing for you to do. If yes, but the answer to the second question is no, then you should submit a PR to https://github.com/rust-lang/libc first, and to Nix second. If the answer to both questions is yes, then feel free to submit a PR.
1690: Enable statfs magic constants for target_os = "android" r=rtzoeller a=flxo
The statfs magic constants of file systems types are available on
target_os android and the cfg guard is updated accordingly.
Sync the list of constant with the constants declared in libc.
Fixes#1689
Co-authored-by: Felix Obenhuber <felix@obenhuber.de>
The fs type constants defined in src/sys/statfs are guard by
#[cfg(all(target_os = "linux", not(target_env = "musl")))]
and therefore not available fortarget_os = "android
. That hit me while patching cgroups-rs for Android and adding thetarget_os = "android"
guard hereAny change to get this updated to
#[cfg(any(all(target_os = "linux", not(target_env = "musl")), target_os = "android"))]
?If yes I can prepare a PR.
Thanks!
The text was updated successfully, but these errors were encountered: