Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs are not being updated in S3 #320

Closed
kamalmarhubi opened this issue Mar 17, 2016 · 6 comments · Fixed by #374
Closed

Docs are not being updated in S3 #320

kamalmarhubi opened this issue Mar 17, 2016 · 6 comments · Fixed by #374

Comments

@kamalmarhubi
Copy link
Member

Compare, for example:

rustdoc.s3-website-us-east-1.amazonaws.com/nix/master/linux/src/nix/sys/uio.rs.html
https://github.com/nix-rust/nix/blob/master/src/sys/uio.rs

The S3 version is missing the fact that #304 got rid of mod ffi in that module.

@posborne
Copy link
Member

Homm, problem is probably the repo line? https://github.com/nix-rust/nix/blob/master/.travis.yml#L72

  on:
    condition: "\"$TRAVIS_RUST_VERSION/$ARCH\" == \"1.1.0/x86_64\""
    repo: carllerche/nix-rust
    branch:
      - master

@homu homu closed this as completed in #374 Jun 3, 2016
homu added a commit that referenced this issue Jun 3, 2016
Fix deployment of docs from travis.

The problem in the repo line in the travis config, I guess it hasn't been updated since ownership was transferred. See: https://travis-ci.org/nix-rust/nix/jobs/131751025#L614

Should resolve #320

Thanks!
@fiveop
Copy link
Contributor

fiveop commented Jun 3, 2016

My comment on #374 is wrong. I can't see the changes of c1334f5. Something is missing. However the new repo is certainly correct.

@fiveop fiveop reopened this Jun 3, 2016
@posborne
Copy link
Member

posborne commented Jun 3, 2016

I feel it might make sense to just move the docs to Github Pages? I have used that quite successfully in the past.

@fiveop
Copy link
Contributor

fiveop commented Jun 3, 2016

Can we automate that it some way?

@posborne
Copy link
Member

posborne commented Jun 3, 2016

@fiveop Yes, travis-cargo looks like it would be useful here: https://github.com/huonw/travis-cargo. Previously, I have just done something like this: https://github.com/rust-embedded/rust-sysfs-gpio/blob/master/.travis.yml#L27. To make that work, you need to setup a key in github http://stackoverflow.com/questions/23277391/how-to-publish-to-github-pages-from-travis-ci

@Susurrus
Copy link
Contributor

We're no longer uploading docs to S3, given that https://docs.rs seems to be handling the situation just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants