Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or revamp sys::syscall module #341

Closed
kamalmarhubi opened this issue Apr 4, 2016 · 2 comments
Closed

Remove or revamp sys::syscall module #341

kamalmarhubi opened this issue Apr 4, 2016 · 2 comments

Comments

@kamalmarhubi
Copy link
Member

This came up in a comment from @pnkfelix on #339.

This module appears to be Linux specific. It declares

extern {
    pub fn syscall(num: Syscall, ...) -> c_int;
}

for all architectures, with Syscall being architecture dependent alias that is c_long on all listed architectures.

On Linux, [syscall(2)][syscall] should return a long, so this declaration is incorrect. We should switch to using definitions from libc and tidy up or remove this module.

Related: #264

@kamalmarhubi
Copy link
Member Author

This PR is related: rust-lang/libc#374

@Susurrus
Copy link
Contributor

Susurrus commented Nov 5, 2017

Closed by #747

@Susurrus Susurrus closed this as completed Nov 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants