Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libc's syscall declaration. #345

Closed
wants to merge 1 commit into from
Closed

Use libc's syscall declaration. #345

wants to merge 1 commit into from

Conversation

fiveop
Copy link
Contributor

@fiveop fiveop commented Apr 7, 2016

Another proposal for fixing an issue ( #341 ). I decided against removing the module, since the constants defined in there are used and they are not defined in libc.

@kamalmarhubi
Copy link
Member

@fiveop

since the constants defined in there are used and they are not defined in libc.

Do you mean the constants are used inside nix, or by users of nix? I think if within nix, we should get rid of any such uses. For users of nix, I think the eventual destiny of this module is to be removed, so it's a matter of when they have to work around that. Or do you think the module should remain, even if all constants are added to libc?

@kamalmarhubi
Copy link
Member

A heroic PR on libc is in progress to bring in the syscall numbers: rust-lang/libc#374

@kamalmarhubi
Copy link
Member

At least on Linux

@fiveop
Copy link
Contributor Author

fiveop commented Sep 9, 2016

I was about to close this PR, when you started your triaging spree. I think #341 is enough of a reminder, and once I or someone else feels like it, can start afresh. So let's close it.

@fiveop fiveop closed this Sep 9, 2016
@fiveop fiveop deleted the syscall branch February 26, 2017 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants