-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nix 0.8.0 fails to build on FreeBSD 10.3 #567
Comments
Compile errors should be fixed by #553, though the PR appears stalled. |
Okay, great. Mind pinging me a new release is made, then I can test? |
This seems bad. I'm going to try and make a point release to include the build fix this weekend. Will ping when done. |
Note that a lot of this termios stuff is fixed in my stalled PR #527. There is a lot of stuff now in Also, with the work ongoing in #536 we should try to add FreeBSD in there if we don't want to repeat these issues. |
Also, according to the changes in #536 all this work is already done in the |
Sorry for ping on this, |
It's fixed in the new-ci/master branch. Finishing that branch and merging it is our highest priority ATM. But in the meantime, you can use it. The last known bug only concerns musl. |
I'm not using it directly. |
I haven't found a good way to do it. What I do is clone the project locally and modify its Cargo.toml file to point to the branch I want. Then I modify my project's Cargo.toml file to point to my local clone of the intermediate project using a path directive, like |
Good hint. |
I'm sorry I failed to get to this last week. Is this fixed in nix/master? |
@kamalmarhubi do you mean new-ci/master? Yes, it is. |
My plan is to finalize |
Actually I meant the build failure on FreeBSD. If it's fixed, does anyone know which PR fixed it? |
Cherry-pick: - a859ee3 Switched bsd speed_t def. to libc::speed_t Fixes nix-rust#567
Cherry-pick: - a859ee3 Switched bsd speed_t def. to libc::speed_t Fixes nix-rust#567
@kamalmarhubi We have a breaking API change since 0.8.0, I'd recommend going to 0.9.0. |
@kamalmarhubi , yeah it seems work on my system. |
@mmokhi if it fixes the FreeBSD issues, I'll just make a release. @nix-rust/nix-maintainers can I get a 👍 on releasing https://github.com/kamalmarhubi/nix-rust/tree/fix-bsd-0.8.1 as v0.8.1? The diff vs v0.8.0 is here: v0.8.0...kamalmarhubi:fix-bsd-0.8.1 |
v0.8.1 was released to fix the broken build on FreeBSD. It is v0.8.0 with a859ee3 by cherry-picked. refs nix-rust#567
v0.8.1 was released to fix the broken build on FreeBSD. It is v0.8.0 with a859ee3 cherry-picked. refs nix-rust#567
@kamalmarhubi All good for me, thanks! Sorry I couldn't reply earlier; was away. |
Here's the error log.
The text was updated successfully, but these errors were encountered: