-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermittent test failures in CI #679
Comments
I'm going to work on the |
See #689 for a potential fix to the |
I checked off everything that was disabled by #689. I want to wait a few more days to see if |
Yeah, but we probably want to add an automatic retry mechanism to cross, rustup, or cargo to try it 3 different times and only bail out then. It's annoying that we need to deal with those kinds of failures when those tools should handle it gracefully. |
AFAIK, there's no guarantee that file descriptors are allocated monotonically, possibly the |
Yeah, that seems right to me. Additionally that value should not even be provided by the user to our version of |
Actually, there is a guarantee that file descriptors be allocated monotonically: http://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html#tag_15_14 . The problem is that this one particular test isn't thread safe: it can fail like this:
|
701: Calculate `nfds` parameter for `select` r=asomers Doing this behind the scenes makes the API less error-prone and easier to use. It should also fix my issue in #679 (comment)
I haven't seen any intermittent failures for a few months now, so I'm going to close the issue. If any new intermittent failures pop up in the future, open a new issue. |
The following tests have been observed to fail occasionally in CI. If you find a fix for one of them, check it off:
sys::test_aio::test_aio_cancel_all
times out on powerpc-unknown-linux-gnu (https://travis-ci.org/nix-rust/nix/jobs/252267360 https://travis-ci.org/nix-rust/nix/jobs/251497766 https://travis-ci.org/nix-rust/nix/jobs/253133267)errno::test::test_errno_values
times out on powerpc-unknown-linux-gnu (https://travis-ci.org/nix-rust/nix/jobs/252157518 https://travis-ci.org/nix-rust/nix/jobs/249711100)test_unistd::test_wait
times out on x86_64-unknown-linux-gnu (https://travis-ci.org/nix-rust/nix/jobs/251440414 PR Make aio, chdir, and wait tests thread safe #638 might fix this one)sys::test_aio::test_aio_cancel_all
panics in thread_info.rs on powerpc-unknown-linux-gnu (https://travis-ci.org/nix-rust/nix/jobs/249502626)test_double_close
times out on powerpc-unknown-linux-gnu (https://travis-ci.org/nix-rust/nix/jobs/254249145 https://travis-ci.org/nix-rust/nix/jobs/255050223)sys::test_epoll::test_epoll_ctl
panics when unwrappingError::Sys(UnknownErrno)
onx86_64-unknown-linux-gnu
(https://travis-ci.org/nix-rust/nix/jobs/254999411)sys::test_epoll::test_epoll_errno
panics when unwrappingError::Sys(UnknownErrno)
onx86_64-unknown-linux-gnu
(https://travis-ci.org/nix-rust/nix/jobs/254999411)error: component download failed for rust-std-armv7-unknown-linux-gnueabihf
onarmv7-unknown-linux-gnueabihf
(https://travis-ci.org/nix-rust/nix/jobs/254708971)The text was updated successfully, but these errors were encountered: