Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change preadv to work with &[IoVec<...>] instead of &mut [IoVec<...>] #913

Closed
farnoy opened this issue Jun 9, 2018 · 1 comment · Fixed by #914
Closed

Change preadv to work with &[IoVec<...>] instead of &mut [IoVec<...>] #913

farnoy opened this issue Jun 9, 2018 · 1 comment · Fixed by #914

Comments

@farnoy
Copy link
Contributor

farnoy commented Jun 9, 2018

They have the same signature, iovec is not modified by the syscall.
@Susurrus
Copy link
Contributor

Would you be willing to submit a PR fixing this? That'll be the fastest way to get this addressed.

farnoy added a commit to farnoy/nix that referenced this issue Jun 11, 2018
@farnoy
Make preadv take immutable slice of IoVecs, fixes nix-rust#913
c54ff05
@farnoy farnoy mentioned this issue Jun 11, 2018
Merged
farnoy added a commit to farnoy/nix that referenced this issue Jul 3, 2018
@farnoy
Make preadv take immutable slice of IoVecs, fixes nix-rust#913
c39859c
farnoy added a commit to farnoy/nix that referenced this issue Jul 3, 2018
@farnoy
Make preadv take immutable slice of IoVecs, fixes nix-rust#913
db4ea2b
bors bot added a commit that referenced this issue Jul 3, 2018
@bors @farnoy
Merge #914
c62f1f8 
914: Make preadv take immutable slice of IoVecs r=asomers a=farnoy

fixes #913

I filled in the CHANGELOG, but I see that it usually links to PRs and not issues, do you want me to change it or remove and leave for you to describe?

This change seems to be strictly backwards-compatible, I didn't have to change the test for it to work.

Co-authored-by: Jakub Okoński <jakub@okonski.org>
@bors bors bot closed this as completed in #914 Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make preadv take immutable slice of IoVecs farnoy/nix
2 participants
@Susurrus @farnoy