Added ptrace::{getregs, setregs}
#1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not entirely sure why CI is failing; it seems like |
|
Should be easy to debug. Just checkout the libc repository and have a look. It's also possible that the libc repository has errors. If you find one, just send libc a PR. |
|
@asomers CI is passing now. I enabled the calls on only Linux x86_64 and x86 GNU since the struct isn't defined for any other target. In the future I might look into seeing if I can get something similar for other targets, but they're not ones I use myself so I'm a bit hesitant to go mucking around in libc. |
asomers
approved these changes
Jan 10, 2019
bors bot
added a commit
that referenced
this pull request
Jan 10, 2019
1010: Added `ptrace::{getregs, setregs}` r=asomers a=wpovell
I needed `ptrace`'s `getregs` and `setregs` for a project I was working on, so I added them! First time contributor, so let me know if I should change / fix anything. Things work fine in my project which uses both functions, let me know if further testing is needed.
Co-authored-by: Will Povell <william_povell@brown.edu>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed
ptrace'sgetregsandsetregsfor a project I was working on, so I added them! First time contributor, so let me know if I should change / fix anything. Things work fine in my project which uses both functions, let me know if further testing is needed.