Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the tests with libc 0.2.49 and Rust 1.33.0 #1033

Merged
merged 4 commits into from
Mar 4, 2019
Merged

Fix the tests with libc 0.2.49 and Rust 1.33.0 #1033

merged 4 commits into from
Mar 4, 2019

Commits on Mar 4, 2019

  1. Fix the build on OSX with libc 0.2.49 

    Several symbols are now marked as deprecated on OSX.  Fix the build by
marking these symbols' Nix wrappers as deprecated, too.
    @asomers
    asomers committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    04e7551 View commit details
    Browse the repository at this point in the history

  2. Fix test_thread_signal* test failures with Cargo 1.33.0 

    Previous versions of Cargo would create and destroy a new thread for
each test.  Cargo 1.33.0 instead creates a thread pool and reuses the
same thread for multiple tests.  Some Nix tests that changed the
per-thread sigmask began to fail as a result, because they didn't do any
cleanup.

The easiest solution is to spawn a new thread for each of those tests.
    @asomers
    asomers committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    3453a8c View commit details
    Browse the repository at this point in the history

  3. Delete a useless unit test that never did anything.

    @asomers
    asomers committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    719a040 View commit details
    Browse the repository at this point in the history

  4. Reenable test_sigwait on OSX 

    It was disabled long ago and nobody remembered to reenable it.  I'm
guessing it's fixed by now.
    @asomers
    asomers committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    439b930 View commit details
    Browse the repository at this point in the history